Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
41d776a35d | ||
|
|
bcdad2e699 | ||
|
|
ce26676d4e | ||
|
|
f60f9b4079 | ||
|
|
936fd3cf3b |
No files matched your search
@@ -97,6 +97,22 @@ fun PoemScreen(
|
||||
// finds, so the couplet's own actions live at its foot rather than behind a tap between words.
|
||||
var tapped by remember { mutableStateOf<WordTap?>(null) }
|
||||
|
||||
// One side panel at a time. The dictionary and the reading settings both want the left of the
|
||||
// screen, and opening the second put two panels there at once — or, where there was no longer
|
||||
// room for two, left the dictionary as a sheet in the middle of the page while the settings
|
||||
// sat beside it. Either way the reader is asked to look in two places. The settings replace
|
||||
// the dictionary instead; closing them leaves the poem, which is where the reader was.
|
||||
val sidePanelOpen = LocalSidePanelOpen.current
|
||||
LaunchedEffect(sidePanelOpen) { if (sidePanelOpen) tapped = null }
|
||||
|
||||
BoxWithConstraints(Modifier.fillMaxSize()) {
|
||||
// Whether the dictionary gets a column of its own is not a question about the window but
|
||||
// about what is left of this page once the columns have taken theirs. On a book-style
|
||||
// foldable held open in portrait the page is already down to ~450dp, and a panel beside it
|
||||
// left the verse a couple of characters a line. Where it does not fit, the sheet is the
|
||||
// better answer: it covers the foot of the poem but leaves the lines whole.
|
||||
val roomForPanel = wide && maxWidth - DictionaryPanelWidth >= MinPageMeasure
|
||||
|
||||
Load(
|
||||
key = fullUrl,
|
||||
block = { Ganjoor.poem(fullUrl) },
|
||||
@@ -231,7 +247,7 @@ fun PoemScreen(
|
||||
}
|
||||
}
|
||||
}
|
||||
if (wide) {
|
||||
if (roomForPanel) {
|
||||
AnimatedVisibility(
|
||||
visible = tapped != null,
|
||||
enter = expandHorizontally() + fadeIn(),
|
||||
@@ -249,7 +265,7 @@ fun PoemScreen(
|
||||
}
|
||||
}
|
||||
|
||||
if (!wide) {
|
||||
if (!roomForPanel) {
|
||||
tapped?.let { tap ->
|
||||
WordSheet(
|
||||
word = tap.word,
|
||||
@@ -258,6 +274,7 @@ fun PoemScreen(
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/** The positions that make a line of verse; anything else (Single, Paragraph, Comment) is prose. */
|
||||
|
||||
@@ -48,6 +48,22 @@ import com.ganjoor.android.data.LocalAssistant
|
||||
import com.ganjoor.android.data.Pronunciation
|
||||
import com.ganjoor.android.ui.theme.readingStyle
|
||||
|
||||
/**
|
||||
* How wide the dictionary sits beside the poem.
|
||||
*
|
||||
* Narrower than the reading settings, deliberately: the settings fold the columns away and take
|
||||
* the room that frees, while the dictionary is read *against* the line it came from, so the verse
|
||||
* keeps the width instead. A definition is short; a hemistich is not.
|
||||
*/
|
||||
val DictionaryPanelWidth = 216.dp
|
||||
|
||||
/**
|
||||
* The narrowest the page may be left once the dictionary opens beside it. Below this the panel is
|
||||
* not worth its room: on a book-style foldable held open in portrait the columns have already
|
||||
* taken theirs, and a panel there left the verse a couple of characters a line.
|
||||
*/
|
||||
val MinPageMeasure = 400.dp
|
||||
|
||||
/** English prose inside an otherwise right-to-left sheet. */
|
||||
@Composable
|
||||
private fun LeftToRight(content: @Composable () -> Unit) {
|
||||
@@ -102,7 +118,7 @@ fun WordPanel(word: String, onDismiss: () -> Unit, passage: Bookmark? = null) {
|
||||
BackHandler(onBack = onDismiss)
|
||||
Surface(
|
||||
color = MaterialTheme.colorScheme.surfaceContainerLow,
|
||||
modifier = Modifier.width(360.dp).fillMaxHeight(),
|
||||
modifier = Modifier.width(DictionaryPanelWidth).fillMaxHeight(),
|
||||
) {
|
||||
Column(Modifier.statusBarsPadding()) {
|
||||
Row(
|
||||
|
||||
@@ -45,6 +45,10 @@ On large screens, tapping a word opens **WordPanel** on the left instead of the
|
||||
- The poem moves over to make room, so nothing being read is covered.
|
||||
- The tapped word stays highlighted in the verse (`secondary-container` / `on-secondary-container`), on phones too.
|
||||
- ✕ or Back closes the panel.
|
||||
- The panel only opens where the page keeps at least **400dp** beside it. On a book-style
|
||||
foldable held open in portrait the columns have already taken their room, and a panel
|
||||
there left the verse a couple of characters a line. Below that the sheet is used instead:
|
||||
it covers the foot of the poem but leaves the lines whole.
|
||||
|
||||
## Reading settings
|
||||
|
||||
|
||||
Reference in new issue
Block a user