anas/divan
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Bookmark icon and wording: محفوظ کریں / محفوظ شدہ #48

Merged
anas merged 4 commits from feature/bookmark-icon into main 2026-10-08 22:16:04 +00:00
Conversation 0 Commits 4 Files Changed 6 +33 -23
anas commented 2026-10-08 22:03:04 +00:00
Owner
Copy Link

Owner request: a bookmark glyph like Android apps, grey when not selected and coloured when selected.

  • Our own rounded bookmark icon (soft corners, rounded notch, 2px stroke), in the style of the Flaticon pack the owner pointed to but drawn here, so no third-party licence or attribution: grey outline when not set, filled brand red when set. Drawn as a CSS mask, so it follows light/dark themes and scales with the text.
  • Replaces the 🔖 emoji everywhere: نشان buttons on poet, book/chapter and poem pages; per-couplet bookmarks; bookmarked phrases; contents lists and cards; the نشانات tab.
  • Wording (owner request): bookmark buttons on poet, book/chapter and poem pages read محفوظ کریں, and محفوظ شدہ once saved, with the accent colour: filled accent glyph, bold accent text and border, light accent tint. The label follows the state on load and on click. The selection menu's phrase option reads محفوظ کریں.
  • Tested: before/after/reload on poet, chapter and poem pages (محفوظ کریں → محفوظ شدہ, kept after reload); close-up screenshots in light and dark themes.

Tested: screenshots in light and dark themes, one couplet bookmarked (filled red) beside unbookmarked ones (grey outline).

🤖 Generated with Claude Code

Owner request: a bookmark glyph like Android apps, grey when not selected and coloured when selected. - Our own rounded bookmark icon (soft corners, rounded notch, 2px stroke), in the style of the Flaticon pack the owner pointed to but drawn here, so no third-party licence or attribution: grey outline when not set, filled brand red when set. Drawn as a CSS mask, so it follows light/dark themes and scales with the text. - Replaces the 🔖 emoji everywhere: نشان buttons on poet, book/chapter and poem pages; per-couplet bookmarks; bookmarked phrases; contents lists and cards; the نشانات tab. - **Wording** (owner request): bookmark buttons on poet, book/chapter and poem pages read **محفوظ کریں**, and **محفوظ شدہ** once saved, with the accent colour: filled accent glyph, bold accent text and border, light accent tint. The label follows the state on load and on click. The selection menu's phrase option reads **محفوظ کریں**. - Tested: before/after/reload on poet, chapter and poem pages (محفوظ کریں → محفوظ شدہ, kept after reload); close-up screenshots in light and dark themes. Tested: screenshots in light and dark themes, one couplet bookmarked (filled red) beside unbookmarked ones (grey outline). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
anas added 1 commit 2026-10-08 22:03:04 +00:00 
Material Design 'bookmark' / 'bookmark_border' (Apache-2.0) drawn as a CSS mask so it follows the
theme; replaces the 🔖 emoji on bookmark buttons, couplet bookmarks, bookmarked phrases, contents
lists and cards, and the نشانات tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas added 1 commit 2026-10-08 22:05:02 +00:00 
Owner reference: a Flaticon bookmark pack (similar, not the same). Drawn here, so no third-party
licence or attribution; grey outline when not set, filled brand colour when set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas changed title from Bookmark icon like Android apps to Bookmark icon and wording: محفوظ کریں / محفوظ شدہ 2026-10-08 22:07:55 +00:00
anas added 1 commit 2026-10-08 22:07:56 +00:00 
Owner request. Saved state: filled accent-coloured glyph, bold accent text and border, light accent
tint; the label follows the state on load and on click. The selection menu's phrase option and the
couplet bookmark's label use the same words.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas added 1 commit 2026-10-08 22:15:50 +00:00
anas merged commit 098a0185e6 into main 2026-10-08 22:16:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/api

   
area/data

   
area/infra

   
area/site

   
decision

   
deferred

   
i18n/urdu

   
search

   
v2
No Label
area/api
area/data
area/infra
area/site
decision
deferred
i18n/urdu
search
v2
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anas/divan#48
No description provided.
Delete Branch "feature/bookmark-icon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?