anas/divan
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

#25 removing redundant checking for session validity

Browse Source
This commit is contained in:
Hamid Reza Mohammadi 2020-10-31 19:30:17 +03:30
parent 33fd4f2442
commit ac426a2455
2 changed files with 4 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
RMuseum/Controllers/AudioNarrationController.cs
View File

@ -287,20 +287,6 @@ namespace RMuseum.Controllers
public async Task<IActionResult> GetUserNarrationProfiles()
{
Guid loggedOnUserId = new Guid(User.Claims.FirstOrDefault(c => c.Type == "UserId").Value);
Guid sessionId = new Guid(User.Claims.FirstOrDefault(c => c.Type == "SessionId").Value);
RServiceResult<bool> sessionCheckResult = await _appUserService.SessionExists(loggedOnUserId, sessionId);
if (!string.IsNullOrEmpty(sessionCheckResult.ExceptionString))
{
return BadRequest(sessionCheckResult.ExceptionString);
}
if(!sessionCheckResult.Result)
{
return BadRequest("نشست کاربر معتبر نیست.");
}
var res = await _audioService.GetUserNarrationProfiles(loggedOnUserId);
if (!string.IsNullOrEmpty(res.ExceptionString))
return BadRequest(res.ExceptionString);
@ -384,14 +370,11 @@ namespace RMuseum.Controllers
/// <summary>
/// constructor
/// </summary>
/// <param name="audioService">
/// </param>
/// <param name="appUserService"></param>
/// <param name="audioService"></param>
/// <param name="userPermissionChecker"></param>
public AudioNarrationController(IAudioNarrationService audioService, IAppUserService appUserService, IUserPermissionChecker userPermissionChecker)
public AudioNarrationController(IAudioNarrationService audioService, IUserPermissionChecker userPermissionChecker)
{
_audioService = audioService;
_appUserService = appUserService;
_userPermissionChecker = userPermissionChecker;
}
@ -405,9 +388,5 @@ namespace RMuseum.Controllers
/// </summary>
protected IUserPermissionChecker _userPermissionChecker;
/// <summary>
/// IAppUserService instance
/// </summary>
protected IAppUserService _appUserService;
}
}

11
RMuseum/RMuseum.xml
View File

@ -708,13 +708,11 @@
<param name="id"></param>
<returns></returns>
</member>
<member name="M:RMuseum.Controllers.AudioNarrationController.#ctor(RMuseum.Services.IAudioNarrationService,RSecurityBackend.Services.IAppUserService,RSecurityBackend.Services.IUserPermissionChecker)">
<member name="M:RMuseum.Controllers.AudioNarrationController.#ctor(RMuseum.Services.IAudioNarrationService,RSecurityBackend.Services.IUserPermissionChecker)">
<summary>
constructor
</summary>
<param name="audioService">
</param>
<param name="appUserService"></param>
<param name="audioService"></param>
<param name="userPermissionChecker"></param>
</member>
<member name="F:RMuseum.Controllers.AudioNarrationController._audioService">
@ -727,11 +725,6 @@
IUserPermissionChecker instance
</summary>
</member>
<member name="F:RMuseum.Controllers.AudioNarrationController._appUserService">
<summary>
IAppUserService instance
</summary>
</member>
<member name="T:RMuseum.Controllers.AuditLogController">
<summary>
Audit Log Controller Base