From ac426a2455ed7f1ecf7ba26a8197145e0e23fc6f Mon Sep 17 00:00:00 2001 From: Hamid Reza Mohammadi Date: Sat, 31 Oct 2020 19:30:17 +0330 Subject: [PATCH] #25 removing redundant checking for session validity --- .../Controllers/AudioNarrationController.cs | 25 ++----------------- RMuseum/RMuseum.xml | 11 ++------ 2 files changed, 4 insertions(+), 32 deletions(-) diff --git a/RMuseum/Controllers/AudioNarrationController.cs b/RMuseum/Controllers/AudioNarrationController.cs index 69c940cf..01a82657 100644 --- a/RMuseum/Controllers/AudioNarrationController.cs +++ b/RMuseum/Controllers/AudioNarrationController.cs @@ -287,20 +287,6 @@ namespace RMuseum.Controllers public async Task GetUserNarrationProfiles() { Guid loggedOnUserId = new Guid(User.Claims.FirstOrDefault(c => c.Type == "UserId").Value); - Guid sessionId = new Guid(User.Claims.FirstOrDefault(c => c.Type == "SessionId").Value); - - RServiceResult sessionCheckResult = await _appUserService.SessionExists(loggedOnUserId, sessionId); - if (!string.IsNullOrEmpty(sessionCheckResult.ExceptionString)) - { - return BadRequest(sessionCheckResult.ExceptionString); - } - - if(!sessionCheckResult.Result) - { - return BadRequest("نشست کاربر معتبر نیست."); - } - - var res = await _audioService.GetUserNarrationProfiles(loggedOnUserId); if (!string.IsNullOrEmpty(res.ExceptionString)) return BadRequest(res.ExceptionString); @@ -384,14 +370,11 @@ namespace RMuseum.Controllers /// /// constructor /// - /// - /// - /// + /// /// - public AudioNarrationController(IAudioNarrationService audioService, IAppUserService appUserService, IUserPermissionChecker userPermissionChecker) + public AudioNarrationController(IAudioNarrationService audioService, IUserPermissionChecker userPermissionChecker) { _audioService = audioService; - _appUserService = appUserService; _userPermissionChecker = userPermissionChecker; } @@ -405,9 +388,5 @@ namespace RMuseum.Controllers /// protected IUserPermissionChecker _userPermissionChecker; - /// - /// IAppUserService instance - /// - protected IAppUserService _appUserService; } } diff --git a/RMuseum/RMuseum.xml b/RMuseum/RMuseum.xml index d6bc3e66..8b5c1053 100644 --- a/RMuseum/RMuseum.xml +++ b/RMuseum/RMuseum.xml @@ -708,13 +708,11 @@ - + constructor - - - + @@ -727,11 +725,6 @@ IUserPermissionChecker instance - - - IAppUserService instance - - Audit Log Controller Base