Commit Graph

439 Commits

Author SHA1 Message Date
Ritiek Malhotra
e6829a1139 Add a changelog entry for #420 2020-01-13 20:25:40 +05:30
Ritiek Malhotra
3e2e8ed0fb Trim '?<key>' when extracting ID from HTTP URLs
If this excess part isn't trimmed from the ID, it can cause unexpected
results when calling some API methods.

For example; this code now correctly returns all albums for an artist:
```
artist = 'https://open.spotify.com/artist/7oPftvlwr6VrsViSDV7fJY?si=M3PrzRC4TBOZu8YyLYc-tA'
artist_albums = sp.artist_albums(artist)
```

Previously, this code mimicked same behaviour as calling
`spotify.artist`, but now will return albums as expected
with this commit.

Fixes #365 and #323.
2020-01-13 20:24:53 +05:30
Peter Bengtsson
4ec320774d Don't require mock for install (#419)
Fixes #418
2020-01-13 14:23:51 +00:00
Stephane Bruckert
cc572364cb Update changelog 2020-01-12 16:06:50 +00:00
David Anderson Lino de Sousa
b12281e761 Fix invalid calls to logging method (#297)
The `_warn` method expects a String, and not a Format String + arguments
2020-01-12 15:29:17 +00:00
Matt John
1609edd4a8 Fix bug where formatted arguments are passed to self._warn, which only accepts a single string (#371) 2020-01-12 15:29:04 +00:00
Stéphane Bruckert
c3bad99e43
Revert "Remove unnecessary token_info parameter for oauth2.SpotifyClientCredentials methods (#223)" (#417)
This reverts commit 908a92897b.
2020-01-12 15:14:25 +00:00
Ritiek Malhotra
908a92897b Remove unnecessary token_info parameter for oauth2.SpotifyClientCredentials methods (#223) 2020-01-12 15:13:31 +00:00
Stephane Bruckert
eaca998123 Bump to 2.6.0 2020-01-12 14:42:52 +00:00
Stéphane Bruckert
f54830e272
Add linter, solves #348 (#415) 2020-01-12 13:19:40 +00:00
Stéphane Bruckert
5928981e3b
Add Github action to check lint 2020-01-12 13:18:34 +00:00
Stéphane Bruckert
b1ceab2b8f
Merge pull request #392 from TimJay/master
requests_cache compatibility
2020-01-12 01:48:16 +00:00
Stéphane Bruckert
9b3b61bdc4
Merge pull request #224 from foxyblue/clean-examples
Clean examples
2020-01-12 00:48:11 +00:00
Stéphane Bruckert
549e692af6
Merge pull request #235 from amsimoes/patch-1
Fixes typo on recommendations usage comment
2020-01-12 00:42:08 +00:00
Stephane Bruckert
c4b302b4e2 Fix example 2020-01-12 00:22:57 +00:00
Stéphane Bruckert
3b2b05769a
Merge pull request #219 from gwynnebaer/master
python 3 syntax for print() example in README.md
2020-01-12 00:19:40 +00:00
Stéphane Bruckert
53c4f30e9c
Merge pull request #368 from s2t2/patch-1
Update oauth2 Docs
2020-01-12 00:12:23 +00:00
Stéphane Bruckert
2be6763d0d
Merge pull request #303 from wdr1/patch-1
Update create_playlist.py
2020-01-12 00:10:03 +00:00
Stéphane Bruckert
8f548bbbe0
Merge pull request #326 from Ondkloss/patch-1
Fixed docstring error
2020-01-12 00:07:42 +00:00
Stephane Bruckert
36f8e1d465 Remove unused VERSION from init 2020-01-12 00:04:40 +00:00
Stéphane Bruckert
63c1aa4ffc
Merge pull request #395 from apuchitnis/patch-1
improve redirect wording and fix minor bugs
2020-01-11 23:52:13 +00:00
Stéphane Bruckert
280e140b40
Merge branch 'master' into patch-1 2020-01-11 23:51:58 +00:00
Stéphane Bruckert
4595b29bd5
Merge pull request #414 from plamere/main-fork-progress
Harrison97 fork progress
2020-01-11 23:38:01 +00:00
Stephane Bruckert
5afaf8f100 Changelog 2020-01-11 23:37:40 +00:00
Stephane Bruckert
6ab96c3c91 Clean up + missing tests 2020-01-11 23:30:57 +00:00
Harrison
62277ac0a8 cast filterObject as list
and change request timeout
2020-01-11 19:56:32 +00:00
Harrison
eec44550fc add simple json to install requirements 2020-01-11 19:56:32 +00:00
Chuan-Zheng Lee
bafef6a175 Make import statements explicit relative imports 2020-01-11 19:56:32 +00:00
Ryan Lee
2aa67580a1 Add current_user_saved_albums_delete method 2020-01-11 19:56:32 +00:00
Ryan Lee
c610090a7c Upload user_saved_albums_delete.py 2020-01-11 19:56:32 +00:00
Harrison
816dd23482 remove unneccessary whitespaces at end of lines 2020-01-11 19:56:32 +00:00
Harrison
3cd252b4c9 update CHANGES.txt 2020-01-11 19:56:32 +00:00
Harrison
d8d9f290fb remove unneccesary whitespaces, shorten some lines, and add name to contibutors 2020-01-11 19:56:00 +00:00
Harrison
43a4de0314 update version and README 2020-01-11 19:56:00 +00:00
Harrison
f1b796cf35 remove duplicate audio_analysis 2020-01-11 19:54:21 +00:00
Ryan K. Lee
5f45a0a54e Update show_album.py
Import SpotifyClientCredentials from spotipy.oauth2
2020-01-11 19:54:21 +00:00
Ryan K. Lee
bd1a122831 Update show_artist.py
Import SpotifyClientCredentials from spotipy.oauth2
2020-01-11 19:54:21 +00:00
Ryan K. Lee
e3185e22ec Update show_artist_top_tracks.py
Import SpotifyClientCredentials from spotipy.oauth2
2020-01-11 19:54:21 +00:00
Ryan K. Lee
90f1105648 Update show_related.py
Import SpotifyClientCredentials from spotipy.oauth2
2020-01-11 19:54:21 +00:00
Ryan K. Lee
5a00758609 Update show_track_info.py
Import SpotifyClientCredentials from spotipy.oauth2
2020-01-11 19:54:21 +00:00
Ryan K. Lee
c3bae42b9e Update simple0.py
Import oath
2020-01-11 19:54:21 +00:00
Ryan K. Lee
0c453c9945 Update simple1.py
Import oath
2020-01-11 19:54:21 +00:00
Ryan K. Lee
a677267bca Update simple2.py
Add import statements for oath
2020-01-11 19:54:21 +00:00
Ryan K. Lee
faa5785a29 Update simple3.py
add import statements for oath
2020-01-11 19:54:21 +00:00
Ryan K. Lee
ba667d388c Update remove_tracks_from_playlist.py
Update comments
2020-01-11 19:54:21 +00:00
Ryan K. Lee
32a6d4867b Update remove_specific_tracks_from_playlist.py
Update comments
2020-01-11 19:54:21 +00:00
Ryan K. Lee
3ed903e6ce Update print parentheses in read_a_playlist.py 2020-01-11 19:54:21 +00:00
Ryan K. Lee
cc158c34f1 Fix comments and parentheses in my_top_tracks.py 2020-01-11 19:54:21 +00:00
Ryan K. Lee
ba6e9a0b79 Add parentheses after print in my_top_artists.py 2020-01-11 19:54:21 +00:00
Ryan K. Lee
91639996e1 Fix comments in my_playlists.py 2020-01-11 19:54:21 +00:00