From b7baaabf7403b1e6c5daf57f4bb6a7ca64cdfef1 Mon Sep 17 00:00:00 2001 From: Beza Amare Amsalu Date: Thu, 30 Mar 2023 13:12:41 -0400 Subject: [PATCH] fixed contributing.md (#955) --- CHANGELOG.md | 3 +++ CONTRIBUTING.md | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 608f0e7..56bbc30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -395,6 +395,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix typos in doc - Start following [SemVer](https://semver.org) properly +### Changed + +- Made instructions in the CONTRIBUTING.md file more clear such that it is easier to onboard and there are no conflicts with TUTORIAL.md ## [2.5.0] - 2020-01-11 Added follow and player endpoints diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e5701b5..688bebc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,7 +8,7 @@ If you would like to contribute to spotipy follow these steps: # Linux or Mac export SPOTIPY_CLIENT_ID=client_id_here export SPOTIPY_CLIENT_SECRET=client_secret_here -export SPOTIPY_CLIENT_USERNAME=client_username_here # This is actually an id not spotify display name +export SPOTIPY_CLIENT_USERNAME=client_username_here # This is actually an id not spotify display name and can be found [here](https://www.spotify.com/us/account/overview/) export SPOTIPY_REDIRECT_URI=http://localhost:8080 # Make url is set in app you created to get your ID and SECRET # Windows @@ -21,9 +21,9 @@ $env:SPOTIPY_REDIRECT_URI="http://localhost:8080" ### Create virtual environment, install dependencies, run tests: ```bash -$ virtualenv --python=python3.7 env +$ virtualenv --python=python3 env $ source env/bin/activate -(env) $ pip install --user -e . +(env) $ pip install -e . (env) $ python -m unittest discover -v tests ```