Fixed lint issues

This commit is contained in:
Peter-Schorn 2021-04-14 12:43:42 -05:00
parent bd80181816
commit 8973fc2e15
5 changed files with 5 additions and 8 deletions

View File

@ -168,7 +168,6 @@ class Spotify(object):
else: # Use the Requests API module as a "session". else: # Use the Requests API module as a "session".
self._session = requests.api self._session = requests.api
def __del__(self): def __del__(self):
"""Make sure the connection (pool) gets closed""" """Make sure the connection (pool) gets closed"""
if isinstance(self._session, requests.Session): if isinstance(self._session, requests.Session):

View File

@ -12,7 +12,6 @@ import base64
import logging import logging
import os import os
import time import time
import warnings
import webbrowser import webbrowser
import requests import requests

View File

@ -5,9 +5,6 @@
__all__ = ["CLIENT_CREDS_ENV_VARS"] __all__ = ["CLIENT_CREDS_ENV_VARS"]
import logging import logging
import os
import warnings
import spotipy
LOGGER = logging.getLogger(__name__) LOGGER = logging.getLogger(__name__)
@ -18,6 +15,7 @@ CLIENT_CREDS_ENV_VARS = {
"redirect_uri": "SPOTIPY_REDIRECT_URI", "redirect_uri": "SPOTIPY_REDIRECT_URI",
} }
def get_host_port(netloc): def get_host_port(netloc):
if ":" in netloc: if ":" in netloc:
host, port = netloc.split(":", 1) host, port = netloc.split(":", 1)

View File

@ -11,6 +11,7 @@ from spotipy import (
import unittest import unittest
from tests import helpers from tests import helpers
def _make_spotify(scopes=None, retries=None): def _make_spotify(scopes=None, retries=None):
retries = retries or Spotify.max_retries retries = retries or Spotify.max_retries
@ -27,6 +28,7 @@ def _make_spotify(scopes=None, retries=None):
return spotify return spotify
class SpotipyPlaylistApiTest(unittest.TestCase): class SpotipyPlaylistApiTest(unittest.TestCase):
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
@ -66,7 +68,6 @@ class SpotipyPlaylistApiTest(unittest.TestCase):
cls.spotify = _make_spotify(scopes=scope) cls.spotify = _make_spotify(scopes=scope)
cls.spotify_no_retry = _make_spotify(scopes=scope, retries=0) cls.spotify_no_retry = _make_spotify(scopes=scope, retries=0)
cls.new_playlist_name = 'spotipy-playlist-test' cls.new_playlist_name = 'spotipy-playlist-test'
cls.new_playlist = helpers.get_spotify_playlist( cls.new_playlist = helpers.get_spotify_playlist(
cls.spotify, cls.new_playlist_name, cls.username) or \ cls.spotify, cls.new_playlist_name, cls.username) or \

View File

@ -6,10 +6,9 @@ import unittest
import six.moves.urllib.parse as urllibparse import six.moves.urllib.parse as urllibparse
from spotipy import SpotifyOAuth, SpotifyPKCE from spotipy import SpotifyOAuth, SpotifyPKCE
from spotipy.cache_handler import CacheHandler
from spotipy.oauth2 import SpotifyClientCredentials, SpotifyOauthError from spotipy.oauth2 import SpotifyClientCredentials, SpotifyOauthError
from spotipy.oauth2 import SpotifyStateError from spotipy.oauth2 import SpotifyStateError
from spotipy import CacheFileHandler from spotipy import MemoryCacheHandler, CacheFileHandler
try: try:
import unittest.mock as mock import unittest.mock as mock
@ -233,6 +232,7 @@ class TestSpotifyClientCredentials(unittest.TestCase):
oauth.get_access_token() oauth.get_access_token()
self.assertEqual(error.exception.error, 'invalid_client') self.assertEqual(error.exception.error, 'invalid_client')
class SpotifyPKCECacheTest(unittest.TestCase): class SpotifyPKCECacheTest(unittest.TestCase):
@patch.multiple(SpotifyPKCE, @patch.multiple(SpotifyPKCE,