anas/spotipy
1
0
Fork 0
mirror of https://github.com/spotipy-dev/spotipy.git synced 2026-06-19 01:03:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve logging (#1191)

Browse Source 
* improve retry warning

* changelog

* fix lint issue
This commit is contained in:
Niko 2025-03-26 07:41:07 +01:00 committed by GitHub
parent 4f01f7187d
commit 3ec8a2312c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -27,6 +27,7 @@ Add your changes below.
- Updated documentation for `Client.current_user_top_artists` to indicate maximum number of artists limit - Updated documentation for `Client.current_user_top_artists` to indicate maximum number of artists limit
- Set auth cache file permissions to `600`: https://github.com/spotipy-dev/spotipy/security/advisories/GHSA-pwhh-q4h6-w599 - Set auth cache file permissions to `600`: https://github.com/spotipy-dev/spotipy/security/advisories/GHSA-pwhh-q4h6-w599
- Fixed `__del__` methods by preventing garbage collection for `requests.Session` - Fixed `__del__` methods by preventing garbage collection for `requests.Session`
- Improved retry warning by using `logger` instead of `logging` and making sure that `retry_header` is an int
### Changed ### Changed

9
spotipy/util.py
View File

@ -14,7 +14,7 @@ import urllib3
import spotipy import spotipy
LOGGER = logging.getLogger(__name__) logger = logging.getLogger(__name__)
CLIENT_CREDS_ENV_VARS = { CLIENT_CREDS_ENV_VARS = {
"client_id": "SPOTIPY_CLIENT_ID", "client_id": "SPOTIPY_CLIENT_ID",
@ -68,7 +68,7 @@ def prompt_for_user_token(
redirect_uri = os.getenv("SPOTIPY_REDIRECT_URI") redirect_uri = os.getenv("SPOTIPY_REDIRECT_URI")
if not client_id: if not client_id:
LOGGER.warning( logger.warning(
""" """
You need to set your Spotify API credentials. You need to set your Spotify API credentials.
You can do this by setting environment variables like so: You can do this by setting environment variables like so:
@ -170,8 +170,9 @@ class Retry(urllib3.Retry):
if response: if response:
retry_header = response.headers.get("Retry-After") retry_header = response.headers.get("Retry-After")
if self.is_retry(method, response.status, bool(retry_header)): if self.is_retry(method, response.status, bool(retry_header)):
logging.warning("Your application has reached a rate/request limit. " retry_header = retry_header or 0
f"Retry will occur after: {retry_header}") logger.warning("Your application has reached a rate/request limit. "
f"Retry will occur after: {retry_header} s")
return super().increment(method, return super().increment(method,
url, url,
response=response, response=response,