Keep the reading playing when the poem is scrolled, and let it be scrubbed #4

anas · 2026-10-07T16:25:46Z

anas commented

2026-10-07 16:25:46 +00:00

The bug

The reading stopped the moment you scrolled down the poem.

RecitationPlayer was an item of the LazyColumn, inside the same header item as the breadcrumbs. Scrolling it off screen disposed it, which fired

DisposableEffect(player) { onDispose { player.release() } }

and cut the audio off mid-line.

The fix

The player is now pinned above the scrolling text, between the top bar and the list. It stays in composition for as long as the poem is open, so the reading continues — and it stays in reach while you read further down, which is exactly when a player is wanted.

Seek bar

Added, as asked:

position, a draggable handle, and both times (1:23 … 4:56);
shown only once the length is known — a bar that cannot be dragged anywhere is furniture;
the handle follows the audio on a 250ms poll while playing, and stops fighting the finger while being dragged (scrubbing holds the pending value until the drag ends);
MediaPlayer.seekTo already does this, so no media library was needed — the ponytail: note is updated rather than invalidated.

The bar and its two times are laid out left to right inside the otherwise right-to-left page, because time runs that way whatever the script.

Verified

Pinning confirmed on the tablet (2560×1600): the player bar stays at the top while the couplets scroll behind it. Builds clean, 63 tests pass.

Not verified: actual playback continuing across a scroll. I could not get the emulator to start streaming the MP3 (AudioPlaybackConfiguration … state:idle), so the audio path itself is unproven here — the disposal cause is certain from the code, but a real device is the honest check.

## The bug The reading stopped the moment you scrolled down the poem. `RecitationPlayer` was an item of the `LazyColumn`, inside the same header item as the breadcrumbs. Scrolling it off screen disposed it, which fired ```kotlin DisposableEffect(player) { onDispose { player.release() } } ``` and cut the audio off mid-line. ## The fix The player is now **pinned above the scrolling text**, between the top bar and the list. It stays in composition for as long as the poem is open, so the reading continues — and it stays in reach while you read further down, which is exactly when a player is wanted. ## Seek bar Added, as asked: - position, a draggable handle, and both times (`1:23` … `4:56`); - shown **only once the length is known** — a bar that cannot be dragged anywhere is furniture; - the handle follows the audio on a 250ms poll while playing, and stops fighting the finger while being dragged (`scrubbing` holds the pending value until the drag ends); - `MediaPlayer.seekTo` already does this, so no media library was needed — the `ponytail:` note is updated rather than invalidated. The bar and its two times are laid out **left to right** inside the otherwise right-to-left page, because time runs that way whatever the script. ## Verified Pinning confirmed on the tablet (2560×1600): the player bar stays at the top while the couplets scroll behind it. Builds clean, 63 tests pass. **Not verified:** actual playback continuing across a scroll. I could not get the emulator to start streaming the MP3 (`AudioPlaybackConfiguration … state:idle`), so the audio path itself is unproven here — the disposal cause is certain from the code, but a real device is the honest check.

anas added 1 commit 2026-10-07 16:25:46 +00:00

Keep the reading playing when the poem is scrolled, and let it be scrubbed 488f48ad39

The player was an item of the LazyColumn, so scrolling it off screen disposed
it, and the DisposableEffect that releases the MediaPlayer cut the reading off
mid-line. It is now pinned above the scrolling text: it stays in composition for
as long as the poem is open, and stays in reach while you read further down,
which is when a player is wanted.

A seek bar comes with it — position, a draggable handle, and the two times —
shown only once the length is known, because a bar that cannot be dragged
anywhere is furniture. The handle follows the audio on a 250ms poll while it
plays and stops fighting the finger while it is being dragged. MediaPlayer
already seeks; this needed no media library.

The bar and its times run left to right inside the otherwise right-to-left page,
because time does, whatever the script.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

anas referenced this pull request

2026-10-07 16:34:06 +00:00

Open the dictionary as a sheet where a panel would crush the poem #3

anas referenced this issue from a commit

2026-10-07 16:36:53 +00:00

Merge pull request #4 from anas-rashid/fix/dictionary-panel-crushes-narrow-page

anas closed this pull request

2026-10-07 16:53:19 +00:00