cb7b1b03a3
The Spotify Web API integration stopped working, leaving /spotify unable to suggest songs at all. Replace the artist/album/track search flow with a single box where the user pastes a link to the track on a music service. Links are checked against a hardcoded allow-list of legal streaming and store domains so links to ripped audio cannot be submitted. The check lives in the service layer, not just the page: any authenticated user can POST to /api/ganjoor/song directly and bypass the UI. Hosts are matched against the full host or a dot-prefixed suffix, so look-alikes such as open.spotify.com.evil.com are rejected; https is required, and userinfo and non-default ports are refused. Accepted URLs are canonicalised - https, lowercased host, tracking parameters stripped - so the same track always yields the same stored URL and duplicate detection actually works. Links are stored under one new type, PoemMusicTrackType.MusicUrl, with the platform derived from the host at render time. That needs no migration or backfill, and supporting another service later needs no new enum value. The duplicate check no longer keys on TrackType, which closes a gap where the same URL could be resubmitted as a different type. Several links per poem remain allowed; only an identical URL for the same poem is refused. The Spotify search page and its OAuth plumbing are kept and simply redirect to /musiclink while the existing SpotifyWorking flag is false, so the old flow can be restored if that API ever works again. Track URLs are no longer written through Html.Raw into href attributes. They previously came from the Spotify API; now that they are user supplied, encoding them prevents stored XSS. Also fixes two latent bugs in SuggestSong that this flow would have hit: a null dereference when TrackUrl is empty, and a singer lookup that matched any singer with an empty Url. |
||
|---|---|---|
| .. | ||
| .config | ||
| Controllers | ||
| DbContext | ||
| Migrations | ||
| Models | ||
| Properties | ||
| Services | ||
| Utils | ||
| appsettings.Development.json | ||
| appsettings.json | ||
| global.json | ||
| Program.cs | ||
| RMuseum.csproj | ||
| RMuseum.xml | ||
| RSecurityBackend.xml | ||
| Startup.cs | ||
| WebServiceUrl.cs | ||