anas/divan
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: stop tracking node_modules links (committed by mistake in #78) #89

Merged
anas merged 2 commits from fix/untrack-node-modules into main 2026-10-09 19:48:58 +00:00
Conversation 0 Commits 2 Files Changed 3 +2 -3
anas commented 2026-10-09 17:29:42 +00:00
Owner
Copy Link

What was wrong: my PR #78 committed api/node_modules and web/node_modules as links pointing at /Users/anasrashid/divan/.... The worktree I made it in had those links, and .gitignore's node_modules/ only matches folders, not links.

Effects:

  • every new checkout or worktree got those links;
  • removing a worktree emptied the real package folders through them, which took the local servers down earlier today;
  • a fresh clone, such as the server's Docker build, would get a link pointing nowhere.

Fix:

  • stop tracking both links;
  • .gitignore now has node_modules without the slash, so it matches a folder or a link. Checked: a link at api/node_modules now shows as ignored.

After merging: in ~/divan, git status no longer shows D api/node_modules / D web/node_modules.

🤖 Generated with Claude Code

**What was wrong:** my PR #78 committed `api/node_modules` and `web/node_modules` as **links** pointing at `/Users/anasrashid/divan/...`. The worktree I made it in had those links, and `.gitignore`'s `node_modules/` only matches folders, not links. **Effects:** - every new checkout or worktree got those links; - removing a worktree emptied the real package folders through them, which took the local servers down earlier today; - a fresh clone, such as the server's Docker build, would get a link pointing nowhere. **Fix:** - stop tracking both links; - `.gitignore` now has `node_modules` without the slash, so it matches a folder or a link. Checked: a link at `api/node_modules` now shows as ignored. After merging: in `~/divan`, `git status` no longer shows `D api/node_modules` / `D web/node_modules`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
anas added 2 commits 2026-10-09 17:29:42 +00:00 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas added 1 commit 2026-10-09 17:29:43 +00:00 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas merged commit ce1adc4dcd into main 2026-10-09 19:48:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/api

   
area/data

   
area/infra

   
area/site

   
decision

   
deferred

   
i18n/urdu

   
search

   
v2
No Label
area/api
area/data
area/infra
area/site
decision
deferred
i18n/urdu
search
v2
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anas/divan#89
No description provided.
Delete Branch "fix/untrack-node-modules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?