anas/divan
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix publishing: URL is not a constructor #69

Merged
anas merged 1 commits from fix/url-shadowing into main 2026-10-09 12:59:04 +00:00
Conversation 0 Commits 1 Files Changed 1 +5 -4
anas commented 2026-10-09 12:58:57 +00:00
Owner
Copy Link

A regression from #68, reported by the owner when publishing حدائقِ بخشش.

Cause: #68 added a constant named URL in moderation.ts. It hid the global URL, which dataDir() uses for the default divan-data folder (new URL("../../../divan-data", import.meta.url)). Every publish without DIVAN_DATA_DIR set failed with "URL is not a constructor".

The tests did not catch it because they always set DIVAN_DATA_DIR, so the default is never evaluated there.

Fix: the constants are renamed TARGET_TITLE and TARGET_URL, with a comment saying why.

Checked: npm test 42 pass; the module loads and the default folder resolves without DIVAN_DATA_DIR. The approved revision 215 is untouched and waiting for the owner to publish it.

🤖 Generated with Claude Code

A regression from #68, reported by the owner when publishing حدائقِ بخشش. **Cause:** #68 added a constant named `URL` in moderation.ts. It hid the global `URL`, which `dataDir()` uses for the default divan-data folder (`new URL("../../../divan-data", import.meta.url)`). Every publish without `DIVAN_DATA_DIR` set failed with "URL is not a constructor". The tests did not catch it because they always set `DIVAN_DATA_DIR`, so the default is never evaluated there. **Fix:** the constants are renamed `TARGET_TITLE` and `TARGET_URL`, with a comment saying why. Checked: `npm test` 42 pass; the module loads and the default folder resolves without `DIVAN_DATA_DIR`. The approved revision 215 is untouched and waiting for the owner to publish it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
anas added 1 commit 2026-10-09 12:58:58 +00:00 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anas merged commit cdfa5f9020 into main 2026-10-09 12:59:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area/api

   
area/data

   
area/infra

   
area/site

   
decision

   
deferred

   
i18n/urdu

   
search

   
v2
No Label
area/api
area/data
area/infra
area/site
decision
deferred
i18n/urdu
search
v2
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anas/divan#69
No description provided.
Delete Branch "fix/url-shadowing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?