anas/divan
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid broken poet images while portraits are deferred #4

New Issue
Closed
opened 2026-10-04 22:04:32 +00:00 by anas · 2 comments
anas commented 2026-10-04 22:04:32 +00:00
Owner
Copy Link

Scope: Show a placeholder (or no image) when a poet has no image instead of a broken <img>.

Acceptance criteria: Home and poet pages show no broken images.

Automated validation: Build; rendered HTML has no empty image URLs.

Manual validation: Visual check of the home page.

Dependencies or blockers: none

Tracked in titus-ai projects/divan/TASKS.md.

**Scope:** Show a placeholder (or no image) when a poet has no image instead of a broken `<img>`. **Acceptance criteria:** Home and poet pages show no broken images. **Automated validation:** Build; rendered HTML has no empty image URLs. **Manual validation:** Visual check of the home page. **Dependencies or blockers:** none _Tracked in titus-ai `projects/divan/TASKS.md`._
anas added this to the Phase 2: Reading experience milestone 2026-10-04 22:04:32 +00:00
anas added the
area/site
 label 2026-10-04 22:04:32 +00:00
anas commented 2026-10-04 22:24:59 +00:00
Author
Owner
Copy Link

Progress (8bb26a02): API serves an SVG placeholder; ImageUrl always set; export no longer points at ganjoor.net. Build passes. Pending: runtime check after the API restart.

Progress (8bb26a02): API serves an SVG placeholder; ImageUrl always set; export no longer points at ganjoor.net. Build passes. Pending: runtime check after the API restart.
anas commented 2026-10-08 17:50:24 +00:00
Author
Owner
Copy Link

Verified: /api/divan/poet/image/p1.gif returns 200 image/svg+xml for a poet without a portrait (after fix a5f0f1b7). Closing.

Verified: `/api/divan/poet/image/p1.gif` returns 200 image/svg+xml for a poet without a portrait (after fix a5f0f1b7). Closing.
anas closed this issue 2026-10-08 17:50:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area/api

   
area/data

   
area/infra

   
area/site

   
decision

   
deferred

   
i18n/urdu

   
search

   
v2
No Label
area/api
area/data
area/infra
area/site
decision
deferred
i18n/urdu
search
v2
Milestone
Clear milestone
No items
No Milestone
Phase 2: Reading experience
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anas/divan#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?