fixing the old project errors

controllers/addComments.php

@@ -11,7 +11,7 @@
 ?>
 
 <?php
-	if($_REQUEST['thecomment']!="")
+	if(isset($_REQUEST['thecomment']) && $_REQUEST['thecomment']!="")
 	{
 		require_once("../models/comment.php");
 		$rs = comment ::insertComment($_REQUEST['imgId'],$temp['username'], $_REQUEST['thecomment'] );

controllers/album.php

@@ -1,7 +1,4 @@
 <?php
-error_reporting(0);
-session_start();
-
 if(isset($_SESSION['user']))
 {
 	$user=$_SESSION['user'];
@@ -9,6 +6,7 @@ if(isset($_SESSION['user']))
 else
 {
 	header("Location: ../views/signinPage.php?message=".urlencode("Login Again!"));
+	exit();
 }
 $aerror = "";
 if(isset($_POST['addAlbum']))

controllers/group.php

@@ -1,7 +1,4 @@
 <?php
-error_reporting(0);
-session_start();
-
 if(isset($_SESSION['user']))
 {
 	$user=$_SESSION['user'];
@@ -9,6 +6,7 @@ if(isset($_SESSION['user']))
 else
 {
 	header("Location: ../views/signinPage.php?message=".urlencode("Login Again!"));
+	exit();
 }
 $aerror = "";
 if(isset($_POST['addGroup']))
@@ -16,12 +14,13 @@ if(isset($_POST['addGroup']))
 	$name = $_POST['name'];
 	
 	include_once('../models/group.php');
-	if(group::insertGroup($name))
+	$groupId = group::insertGroup($name);
+	if($groupId)
 	{
-		if(group::insertMember($name, $user['username']))
+		if(group::insertMember($groupId, $user['username']))
 		{
 			$aerror = "Group Created!";
-			header("Location: ../views/allgroups.php");	
+			header("Location: ../views/allgroups.php");
 		}
 	}
 	else

controllers/logout.php

@@ -1,7 +1,10 @@
 <?php
+  session_start();
   if(isset($_POST['signout']))
   {
-    $_SESSION["user"] = "";
-	header("Location: ../views/signinPage.php");	
+    session_unset();
+    session_destroy();
+	header("Location: ../views/signinPage.php");
+	exit();
   }
 ?>

controllers/member.php

@@ -1,7 +1,4 @@
 <?php
-error_reporting(0);
-session_start();
-
 if(isset($_SESSION['user']))
 {
 	$user=$_SESSION['user'];
@@ -9,6 +6,7 @@ if(isset($_SESSION['user']))
 else
 {
 	header("Location: ../views/signinPage.php?message=".urlencode("Login Again!"));
+	exit();
 }
 $uerror = "";
 if(isset($_POST['addToGroup']))

controllers/signin.php

@@ -16,7 +16,6 @@
 			{
 				$myuser= new User($username);
 				$_SESSION["user"] =$myuser->get_values();
-				var_dump($_SESSION["user"]);
 				header("Location: ../views/profilePage.php?username=".$username);
 			}
 			else

controllers/signup.php

@@ -14,7 +14,7 @@
 		}
 		elseif($pass!=$cpass)
 			{
-				$error = "cannot leave any field empty!";
+				$error = "Passwords do not match!";
 			}
 		else
 		{

controllers/upload.php

@@ -1,7 +1,4 @@
 <?php
-error_reporting(0);
-session_start();
-
 if(isset($_SESSION['user']))
 {
 	$user=$_SESSION['user'];
@@ -9,6 +6,7 @@ if(isset($_SESSION['user']))
 else
 {
 	header("Location: ../views/signinPage.php?message=".urlencode("Login Again!"));
+	exit();
 }
 $uerror = "";
 if(isset($_POST['upload']))